feat(network): enable Docker and Podman policy DNS and transparent TCP by johntmyers · Pull Request #2723 · NVIDIA/OpenShell

johntmyers · 2026-08-12T20:25:11Z

Summary

Enables policy-gated DNS and transparent native TCP egress for Docker and Podman sandboxes using the resolved-endpoint primitives introduced by #2713. Existing proxy behavior remains unchanged when protocol is omitted; explicit protocol: tcp selects the native TCP path and fails closed on unsupported compute drivers.

This is PR 3 in the direct DNS + TCP stack and is intentionally based on #2713.

Related Issue

Part of #2712.

Stacked on #2713; review and merge that PR first.

Changes

Shared supervisor implementation

Captures sandbox DNS and TCP inside the workload network namespace before releasing the workload.
Answers only policy-eligible DNS names, publishes epoch-scoped synthetic IPv4 mappings, and returns NOERROR/NODATA for AAAA until a runtime proves usable IPv6 egress.
Redirects connections to synthetic addresses into the supervisor, correlates them with the DNS mapping, applies shared egress policy and process identity, pins the approved real address, and relays raw TCP.
Preserves the existing CONNECT and forward-proxy paths for endpoints without explicit protocol: tcp.
Fails closed for wrong ports, stale or expired mappings, direct real-IP bypass, unsupported runtimes, and uninspectable middleware requirements.
Emits correlated OCSF events for DNS mappings, resolver/publication failures, pool high-water state, and transparent TCP allow/deny decisions.
Redirects workload DNS port 53 to an unprivileged supervisor listener on port 15053.
Handles UDP DNS queries concurrently with a fixed bound and supports multiple length-prefixed queries on one TCP connection.
Expands both synthetic family pools to 512 identities with a shared 1,024-allocation lifetime cap while preserving no-reassignment within an epoch.

Docker enablement

Advertises the driver-owned policy-dns-transparent-tcp runtime capability and overwrites forged image or sandbox environment values.
Reuses Docker's existing supervisor-owned nested network namespace, veth pair, nftables fence, and bridge DNS substrate.
Runs the native TCP E2E scenario in the Docker lane, covering synthetic DNS, bidirectional TCP, wrong-port denial, direct real-IP denial, transparent-listener bypass denial, and OCSF decisions.

Podman enablement

Advertises the same driver-owned runtime capability while preserving the non-forgeable driver boundary.
Uses the unprivileged policy-DNS listener without granting NET_BIND_SERVICE.
Preserves Podman's existing search-domain and resolver-option behavior for sandboxes that do not use native TCP.
Supports UDP DNS through the nested REDIRECT path without forcing libc use-vc, including Alpine/musl coverage.
Runs the same native TCP E2E scenario in the rootless Podman lane on Ubuntu 26.04 with Podman 5.x and pasta.

Unsupported runtimes

Kubernetes and VM drivers do not advertise the runtime capability in this PR. An explicit protocol: tcp policy therefore fails closed before workload startup on those drivers.

Documentation

Updates the canonical policy schema and sandbox policy guide with the completed native DNS and TCP behavior.
Documents the fail-closed DNS correlation boundary, Docker and Podman support, unsupported-runtime behavior, and the explicit-proxy compatibility path.
Updates architecture, Docker and Podman driver documentation, and related agent skills to describe the driver/runtime contract.

Testing

mise run pre-commit
Supervisor-network tests: 1,192 passed, 2 ignored; integrations passed
Podman driver tests: 170 passed
Sandbox library tests: 113 passed; binary and integration tests passed
New Alpine/musl Podman E2E target compiles
Existing Docker and rootless Podman transparent TCP E2E scenarios cover allowed TCP, wrong-port denial, direct-real-IP denial, listener-bypass denial, and OCSF decisions
Required Branch Checks and Branch E2E workflows are rerunning for the current head

Local runtime E2E was not rerun for the review fixes because Podman is not installed and the local Docker daemon is stopped. The pushed stack exercises those paths in CI.

Checklist

Follows Conventional Commits
Commits are signed off (DCO)
Architecture docs updated

copy-pr-bot · 2026-08-12T20:25:15Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: d3192695290c85f5ec09fce8a2ee769f855e9aff
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: baebe64158d4bc837093dfc1b7ead924eccb1c25
Gator payload: 4
Review mode: initial
Previous reviewed SHA: none
Review budget exhausted: no
Maintainer decision required: no

I reviewed only the stage-3 author delta against PR #2713's head. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, Podman, or VM enablement deferred to stage 4.

Blocking findings:

GATOR-d3192695-01 (Critical): A transparent TCP connection must consume a DNS mapping from the same policy generation as its authoritative process and endpoint authorization.
GATOR-d3192695-02 (Critical): Only redirected synthetic-address traffic may bypass the terminal TCP reject; a reserved listener port must never become a general direct-egress allow rule.
GATOR-d3192695-03 (Warning): Transparent TCP upstream dialing must remain bound to the real addresses validated and recorded by policy DNS; corporate-proxy configuration must not re-resolve the logical hostname.
GATOR-d3192695-04 (Warning): Every accepted dynamic protocol: tcp policy must either have a ready transparent substrate on a capable runtime or be rejected explicitly without installing the candidate generation.

Carried findings:

None

Non-blocking suggestions:

None

Docs: Architecture and agent-skill guidance are updated; published release docs remain on the authoritative plan's separate stacked documentation branch.

Next state: gator:in-review

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 74f9fba16f09caa3f31b21bb3f920e3021ea5625
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: 5151ae7e7bdf6418cc18d3447369ebf15e8ae8ac
Gator payload: 4
Review mode: follow_up
Previous reviewed SHA: d3192695290c85f5ec09fce8a2ee769f855e9aff
Review budget exhausted: no
Maintainer decision required: no

I reviewed the four unresolved obligations plus only the author delta since the previous review, within PR #2723's stage-3 boundary against PR #2713. The new commit adds Redis example coverage for blocked hostname, wrong-port, and direct-IP attempts; it does not change the implementation sites underlying the prior findings. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, Podman, or VM enablement deferred to stage 4.

Blocking findings:

No new blocking findings in the follow-up delta.

Carried findings:

GATOR-d3192695-01 (Critical): The transparent connection still needs a same-generation mapping and authoritative authorization check before connector construction.
GATOR-d3192695-02 (Critical): The address-unscoped transparent-listener-port accept rule still bypasses the terminal direct-TCP reject for non-synthetic destinations.
GATOR-d3192695-03 (Warning): Transparent TCP can still ask an upstream proxy to resolve the logical hostname instead of dialing only mapping-pinned addresses.
GATOR-d3192695-04 (Warning): Transparent capability activation and rejection remain startup-only, so a later protocol: tcp policy update can install without a ready substrate or unsupported-runtime rejection.

Docs: The example-only delta improves negative-path documentation; architecture and agent-skill guidance remain present, while published release docs stay on the authoritative plan's separate stacked documentation branch.

Next state: gator:in-review

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 81e56497f9a6ef9a1806896d4eb0f24c829ded0c
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: fb1735d68a0b058353e2644edd2e0bfde7085043
Gator payload: 4
Review mode: follow_up
Previous reviewed SHA: 74f9fba16f09caa3f31b21bb3f920e3021ea5625
Review budget exhausted: yes — this is the third finding-bearing round; any later new-head review is critical-only
Maintainer decision required: no — this round adds no new finding or scope growth; the existing author obligations remain concrete

I reviewed the four unresolved obligations plus only the author delta since the previous review, within PR #2723's stage-3 boundary against PR #2713. The new commit narrows the Redis example's log output to relevant OCSF events; it does not change the implementation sites underlying the prior findings. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, Podman, VM, or other stage-4 enablement.

Blocking findings:

No new blocking findings in the follow-up delta.

Carried findings:

GATOR-d3192695-01 (Critical): The transparent connection still needs a same-generation mapping and authoritative authorization check before connector construction.
GATOR-d3192695-02 (Critical): The address-unscoped transparent-listener-port accept rule still bypasses the terminal direct-TCP reject for non-synthetic destinations.
GATOR-d3192695-03 (Warning): Transparent TCP can still ask an upstream proxy to resolve the logical hostname instead of dialing only mapping-pinned addresses.
GATOR-d3192695-04 (Warning): Transparent capability activation and rejection remain startup-only, so a later protocol: tcp policy update can install without a ready substrate or unsupported-runtime rejection.

Docs: The example-only delta improves OCSF output focus; architecture and agent-skill guidance remain present, while published release docs stay on the authoritative plan's separate stacked documentation branch.

Next state: gator:in-review

github-actions · 2026-08-13T18:18:45Z

Label test:e2e applied for f232d7d. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: f232d7d0bcd6cb737e23dc4080b680c561cc03ae
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: 7c93517daca3e85306c312ccf55aabf780f00015
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 81e56497f9a6ef9a1806896d4eb0f24c829ded0c
Review budget exhausted: yes
Maintainer decision required: no — the carried obligations are resolved, the remediation stays within stage 3, and the critical-only review found no new Critical defect

I reviewed only the latest author delta and the four carried obligations, within PR #2723's stage-3 boundary against PR #2713. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, Podman, VM, or other stage-4 enablement.

Blocking findings:

No blocking findings remain.

Carried findings:

GATOR-d3192695-01 resolved: the adapter pins the authorization generation, reacquires the mapping for that exact generation, and keeps the guard through dialing and relay.
GATOR-d3192695-02 resolved: the nftables exception now requires a mark set only on synthetic-destination redirects, so direct real-IP port-15001 traffic still reaches the terminal reject.
GATOR-d3192695-03 resolved: transparent TCP ignores proxy hostname mode and sends only a mapping-validated IP to the corporate proxy.
GATOR-d3192695-04 resolved: unsupported or startup-unprepared TCP policy expansion is rejected atomically while the previous policy remains active, with focused reload tests and operator diagnostics.

Docs: Architecture and Redis example guidance describe the startup substrate and atomic late-expansion rejection; agent-skill updates remain present. Published release docs remain on the authoritative plan's separate stacked documentation branch.

Tests: test:e2e is required and has been applied. The E2E Label Help workflow is determining the current-head dispatch action; pipeline monitoring begins only after the required workflow is queued.

Next state: gator:in-review

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 02d2e1beb056471c99def74c805f2c15025fb520
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: 2ab7c805e2956e9548eee700df846816c3ed7af0
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: f232d7d0bcd6cb737e23dc4080b680c561cc03ae
Review budget exhausted: yes
Maintainer decision required: no — this latest-delta Critical has a proportionate author resolution; Podman can remain capability-gated for stage 4 or complete its stage-3 substrate contract

I reviewed only the latest author delta against the intentional PR #2713 stack base. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, Podman, VM, or other stage-4 enablement. The latest delta voluntarily enables Podman, so I checked only whether that newly advertised path is safe and operational.

Blocking findings:

GATOR-02d2e1be-01 (Critical): Podman advertises policy DNS and transparent TCP while its container spec still drops the capability required to bind the UDP/TCP policy-DNS listeners on port 53.

Carried findings:

GATOR-d3192695-01 through GATOR-d3192695-04 remain resolved; this delta does not invalidate those dispositions.

Docs: The Podman architecture and skill updates match the intended claim, but that claim cannot become active until the runtime substrate is complete. Published release docs remain on the plan's separate stacked documentation branch.

Next state: gator:in-review

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: c39e4324c9ae03a4c27d96252ac2f895ebf6f90b
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: 1fc151be83ca981d4efb6f46939627fd00787552
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 02d2e1beb056471c99def74c805f2c15025fb520
Review budget exhausted: yes
Maintainer decision required: no — all carried obligations are resolved, the remediation stays within stage 3, and the critical-only review found no new Critical defect

Thanks @johntmyers. I checked the latest Podman capability fix against the port-53 listener requirement: the generated container spec now retains NET_BIND_SERVICE, the capability test covers it, and the driver documentation matches the runtime contract. This resolves GATOR-02d2e1be-01.

I reviewed only the latest author delta against PR #2713's head. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, VM, or other stage-4 enablement.

Blocking findings:

No blocking findings remain.

Carried findings:

GATOR-02d2e1be-01 resolved: Podman now retains the capability required to bind policy DNS UDP/TCP listeners on port 53.
GATOR-d3192695-01 through GATOR-d3192695-04 remain resolved; this delta does not invalidate those dispositions.

Docs: Architecture, driver, example, and agent-skill guidance cover the implementation contract; published release docs remain on the authoritative plan's separate stacked documentation branch.

Tests: test:e2e is applied, and current-head Branch Checks and E2E workflows are running.

Next state: gator:watch-pipeline

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 06abf90cdc52f2615c147342817a0f878004c54a
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: 254b06036d1f5ac2c7cc6d4056409323a95fd5e7
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: c39e4324c9ae03a4c27d96252ac2f895ebf6f90b
Review budget exhausted: yes
Maintainer decision required: no — all carried obligations remain resolved, the delta stays within stage 3, and the critical-only review found no new Critical defect

Thanks @johntmyers. I checked the latest qualified-hostname E2E change against the Docker/Podman network-alias and policy-DNS identity path. The fixture, policy endpoint, native lookup, and OCSF assertions now consistently use transparent-tcp-fixture.openshell.test, preventing runtime resolver search domains from rewriting the intended policy identity.

I reviewed only the latest author delta against PR #2713’s head. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, VM, or other stage-4 enablement.

Blocking findings:

No blocking findings remain.

Carried findings:

GATOR-02d2e1be-01 remains resolved.
GATOR-d3192695-01 through GATOR-d3192695-04 remain resolved; this delta does not invalidate those dispositions.

Docs: No additional docs or skill changes are needed for this E2E-only hostname qualification; the existing stage-3 guidance remains applicable, and published release docs remain on the authoritative plan’s separate stacked documentation branch.

Tests: test:e2e is applied. Current-head Branch Checks and E2E are queued/running.

Next state: gator:watch-pipeline

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 39cb220e5bab58002699a6090f8d44da4173d2e0
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: 8c2d64a6dfbf943a2ca4443f7660a61d6aefa32a
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 06abf90cdc52f2615c147342817a0f878004c54a
Review budget exhausted: yes
Maintainer decision required: no — all carried obligations remain resolved, this delta does not cross the stage boundary, and the critical-only review found no new Critical defect

Thanks @johntmyers. I checked the latest Podman DNS-search fix against the exact policy-DNS name contract. The container spec now requests Podman’s documented . search list, its serialization is covered, and the driver documentation describes the behavior consistently.

I reviewed only the latest author delta against PR #2713’s head. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, Podman, VM, or other stage-4 enablement. Because this PR already voluntarily activates Podman, I checked only whether the latest Podman remediation introduced a new Critical defect.

Blocking findings:

No blocking findings remain.

Carried findings:

GATOR-02d2e1be-01 remains resolved.
GATOR-d3192695-01 through GATOR-d3192695-04 remain resolved; this delta does not invalidate those dispositions.

Docs: The Podman runtime documentation now records the exact-name resolver behavior. Existing architecture, driver, example, and agent-skill guidance remain applicable; published release docs remain on the authoritative plan’s separate stacked documentation branch.

Tests: test:e2e is applied. Current-head Branch Checks, Helm Lint, and E2E workflow dispatch is being monitored.

Next state: gator:watch-pipeline

johntmyers

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 93a25073dd6e96ee2fee49d2df4bdb78d3b8cde3
Base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Merge base SHA: 17a43d8ce788eb2dd27b5a2910649864b5f72f1b
Patch ID: 6c3e9361fcfd0af165ccac983c16f5932cd13198
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 39cb220e5bab58002699a6090f8d44da4173d2e0
Review budget exhausted: yes
Maintainer decision required: no — all carried obligations remain resolved, the delta stays within stage 3, and the critical-only review found no new Critical defect

I reviewed only the latest author delta against PR #2713’s head. I did not re-review inherited stage-1/stage-2 code or require Kubernetes sidecar, VM, or other stage-4 enablement. Because this PR already voluntarily activates Podman, I checked the new Podman TCP resolver routing and the DNS-over-TCP multi-query handling only for a newly introduced Critical defect.

Blocking findings:

No blocking findings remain.

Carried findings:

GATOR-02d2e1be-01 remains resolved.
GATOR-d3192695-01 through GATOR-d3192695-04 remain resolved; this delta does not invalidate those dispositions.

Docs: Podman runtime guidance documents TCP policy-DNS resolver routing; existing architecture, driver, example, and agent-skill guidance remain applicable. Published release docs remain on the authoritative plan’s separate stacked documentation branch.

Tests: test:e2e remains applied. Current-head Branch Checks and E2E workflows are running; Helm Lint is green.

Next state: gator:watch-pipeline

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-08-19T23:48:59Z

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 6c93117f6372fdf8cf2630a2322c90df0ca3a158
Base SHA: 8a7b2f638f498d9c19489ed45778beed69df294b
Merge base SHA: 8a7b2f638f498d9c19489ed45778beed69df294b
Patch ID: 3c443ac728d91e4e3ec238c67eee1e2be012baf0
Gator payload: 4
Review mode: already_reviewed
Previous reviewed SHA: 20ade8caf5c000350925983feedf11e479c2fe7b
Review budget exhausted: yes
Maintainer decision required: no — the effective stage-3 author patch is rebase-equivalent and the remaining obligation is a concrete current-head E2E failure

I checked @johntmyers's current rebase against PR #2713's stack base, not the cumulative main-branch diff. The review ledger reports the same effective author patch as the prior reviewed head, so I did not run another reviewer or re-review inherited stage-1/stage-2 code. Kubernetes sidecar, Kubernetes combined, VM, and other stage-4 enablement remain outside this PR's required boundary; Podman is in scope because this PR enables it.

Blocking review findings:

No new code-review finding; all durable Gator findings remain resolved.

Current-head test obligation:

Branch E2E run 32309578611 failed in the supported rootless Podman path. local_container_native_tcp_uses_policy_dns_and_fails_closed reached the native TCP echo assertion at e2e/rust/tests/transparent_tcp.rs:345, but recv(1024) returned ConnectionResetError: [Errno 104] Connection reset by peer. This directly exercises stage-3 policy DNS and transparent TCP, so the required OpenShell / E2E gate is not green.

Docs: Existing policy-schema, sandbox, architecture, Docker/Podman, example, and agent-skill guidance continue to cover the stage-3 contract.

Next action: @johntmyers, please diagnose and fix the current-head Podman transparent-TCP failure, or provide concrete evidence that it is infrastructure/flaky behavior so a maintainer can make the appropriate rerun decision.

Next state: gator:in-review

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-08-20T00:17:58Z

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 162c1331e1cf2ef662aeef199e8ab0de2227f907
Base SHA: 8a7b2f638f498d9c19489ed45778beed69df294b
Merge base SHA: 8a7b2f638f498d9c19489ed45778beed69df294b
Patch ID: aef69be7a666bfe752afe691084a9648c8f52912
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 6c93117f6372fdf8cf2630a2322c90df0ca3a158
Review budget exhausted: yes
Maintainer decision required: no — all durable findings remain resolved, the latest E2E-readiness correction stays within the voluntarily enabled Podman path, and the critical-only author-delta review found no newly introduced Critical defect

Thanks @johntmyers. I checked only the latest author commit against PR #2713's current stack base. The test fixture now binds all three TCP listeners before any serving thread starts, removing the readiness race behind the prior Podman E2E connection reset without changing production behavior.

I did not review the cumulative main-branch diff, re-review inherited stage-1/stage-2 code, or require Kubernetes sidecar, Kubernetes combined, Podman, VM, or other stage-4 enablement. Podman was inspected only because this PR voluntarily enables it and this delta directly fixes its required E2E lane.

Blocking findings:

No blocking findings remain.

Carried findings:

GATOR-02d2e1be-01 remains resolved.
GATOR-d3192695-01 through GATOR-d3192695-04 remain resolved; this test-only delta does not invalidate those dispositions.

Docs: No documentation or skill update is needed for this E2E fixture-readiness correction; the existing policy, sandbox, architecture, Docker/Podman, example, and agent-skill guidance continue to cover the implemented stage-3 contract.

Tests: test:e2e remains applied. Current-head Branch Checks and Branch E2E are queued/running; DCO, docs preview, Helm Lint, GPU E2E, and completed required-gate publication are green.

Next state: gator:watch-pipeline

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-08-20T00:54:16Z

PR Review Status

Validation: Project-valid stage 3 of issue #2712, intentionally stacked on stage-2 PR #2713.
Head SHA: 2e919c0e5d69d138d09d18f7a84e8063178398d0
Base SHA: 8a7b2f638f498d9c19489ed45778beed69df294b
Merge base SHA: 8a7b2f638f498d9c19489ed45778beed69df294b
Patch ID: 1516873a6f17c875c445a493c09aaf478bca0f83
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 162c1331e1cf2ef662aeef199e8ab0de2227f907
Review budget exhausted: yes
Maintainer decision required: no — all durable findings remain resolved, the latest test-fixture correction stays within the voluntarily enabled Podman E2E path, and the critical-only author-delta review found no newly introduced Critical defect

Thanks @johntmyers. I checked only the latest author commit against PR #2713's current stack base. The test harness now grants NET_BIND_SERVICE only to the support container used by the transparent-TCP E2E fixture, allowing its TCP/53 listener to bind while leaving production runtime capability behavior unchanged.

I did not review the cumulative main-branch diff, re-review inherited stage-1/stage-2 code, or require Kubernetes sidecar, Kubernetes combined, Podman, VM, or other stage-4 enablement. Podman was inspected only because this PR voluntarily enables it and the delta directly repairs that E2E lane.

Blocking findings:

No blocking findings remain.

Carried findings:

GATOR-02d2e1be-01 remains resolved.
GATOR-d3192695-01 through GATOR-d3192695-04 remain resolved; this test-only delta does not invalidate those dispositions.

Docs: No documentation or skill update is needed for this E2E fixture-capability correction; the existing policy, sandbox, architecture, Docker/Podman, example, and agent-skill guidance continue to cover the implemented stage-3 contract.

Tests: test:e2e remains applied. Current-head Branch Checks and Branch E2E are queued/running; DCO, docs preview, Helm Lint, and completed required-gate publication are green.

Next state: gator:watch-pipeline

johntmyers marked this pull request as ready for review August 13, 2026 01:04

johntmyers requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners August 13, 2026 01:04

johntmyers commented Aug 13, 2026

View reviewed changes

Comment thread crates/openshell-supervisor-network/src/proxy.rs

Comment thread crates/openshell-supervisor-process/src/netns/nft_ruleset.rs Outdated

Comment thread crates/openshell-supervisor-network/src/proxy.rs Outdated

Comment thread crates/openshell-sandbox/src/lib.rs

johntmyers added the gator:in-review Gator is reviewing or awaiting PR review feedback label Aug 13, 2026

johntmyers commented Aug 13, 2026

View reviewed changes

johntmyers added the test:e2e Requires end-to-end coverage label Aug 13, 2026

johntmyers commented Aug 13, 2026

View reviewed changes

Comment thread crates/openshell-driver-podman/src/container.rs

johntmyers added gator:in-review Gator is reviewing or awaiting PR review feedback and removed gator:approval-needed Gator completed review; maintainer approval needed labels Aug 13, 2026

johntmyers commented Aug 13, 2026

View reviewed changes

johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status and removed gator:in-review Gator is reviewing or awaiting PR review feedback labels Aug 13, 2026

johntmyers commented Aug 13, 2026

View reviewed changes

johntmyers added gator:approval-needed Gator completed review; maintainer approval needed and removed gator:watch-pipeline Gator is monitoring PR CI/CD status labels Aug 14, 2026

johntmyers changed the title ~~feat(network): enable Docker policy DNS and transparent TCP~~ feat(network): enable Docker and Podman policy DNS and transparent TCP Aug 14, 2026

johntmyers added 22 commits August 19, 2026 15:36

fix(ci): satisfy Linux transparent TCP lints

f0f1b99

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

feat(podman): enable transparent TCP egress

6a2fa5f

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(podman): permit policy DNS port binding

55ef01b

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

test(e2e): use qualified transparent TCP hostname

1781ab8

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(podman): preserve exact policy DNS names

cbed03d

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(podman): route policy DNS over TCP

009c720

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(dns): serve multiple TCP queries per connection

0408645

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

docs(network): explain native DNS and TCP egress

a815b0c

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(sandbox): reconcile runtime reload with upstream

9ba39a8

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(network): harden transparent DNS capture

dbdd8bb

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(podman): preserve resolver behavior for native tcp

e3c6f75

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

docs(network): clarify native tcp runtime constraints

228c59e

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(network): remove unused transparent tcp pin

56533e2

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(network): admit redirected transparent tcp

4ba61b8

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(network): restore podman transparent networking

a683fb5

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

test(podman): permit alpine busybox binaries

987ff52

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

test(podman): use portable alpine keepalive

d3d6604

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

test(podman): build musl networking fixture

50734bd

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

test(podman): isolate musl DNS probe

0b31183

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(podman): keep privileged port capability dropped

9d2b212

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(network): preserve transparent TCP port 53

5795af3

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

fix(network): report synthetic pool pressure by family

6c93117

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

test(podman): bind tcp fixtures before readiness

162c133

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

pimlock previously approved these changes Aug 20, 2026

View reviewed changes

test(podman): grant fixture low-port bind

2e919c0

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

pimlock approved these changes Aug 20, 2026

View reviewed changes

Uh oh!

Conversation

johntmyers commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Shared supervisor implementation

Docker enablement

Podman enablement

Unsupported runtimes

Documentation

Testing

Checklist

Uh oh!

copy-pr-bot Bot commented Aug 12, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers commented Aug 19, 2026

PR Review Status

Uh oh!

johntmyers commented Aug 20, 2026

PR Review Status

Uh oh!

johntmyers commented Aug 20, 2026

PR Review Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johntmyers commented Aug 12, 2026 •

edited

Loading